Issue 53534: Support Microsoft's Graph Protocol API for authentication via OAuth2 token #2881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
requested changes
Feb 10, 2026
| public void doStartup(ModuleContext moduleContext) | ||
| { | ||
| if (AppProps.getInstance().isMailRecorderEnabled()) | ||
| if (MailHelper.getActiveProvider() instanceof SmtpTransportProvider && AppProps.getInstance().isMailRecorderEnabled()) |
Member
There was a problem hiding this comment.
Maybe add this check to DumbsterManager.start to prevent it from being started by other means (e.g. DumbsterController.SetRecordEmailAction). It should also log some sort of error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The related PRs adds Microsoft Graph as an alternative mail transport using OAuth2 authentication. Since Dumbster is an SMTP-only mail recorder, it should only start when SMTP is the active transport.
Related Pull Requests
Changes